Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue Report]: No differentiation between keymapper and padmapper in German translation #7187

Open
Gunnar-GO opened this issue Jul 12, 2024 · 5 comments

Comments

@Gunnar-GO
Copy link

Operating System

Windows x64

DevilutionX version

1.5.2

Describe

At the xbox port i have under options a dupe entry of control settings, "Tastaturbelegung" at least in the german translation, other i didn't checked before. This should be a minor, since is a dupe, so maybe an duped line etc.

Actually the Translation is not the best since at last half of the ports should use other controls than a keyboard.

To Reproduce

Go to settings.

Expected Behavior

1 entry

Additional context

No response

@StephenCWills
Copy link
Member

It's not a duplicate entry, it's an issue with the translation.

devilutionX/Translations/de.po

Lines 7198 to 7212 in 7211958

#: Source/options.cpp:1293
msgid "Keymapping"
msgstr "Tastaturbelegung"
#: Source/options.cpp:1293
msgid "Keymapping Settings"
msgstr "Tastaturbelegungseinstellungen"
#: Source/options.cpp:1516
msgid "Padmapping"
msgstr "Tastaturbelegung"
#: Source/options.cpp:1516
msgid "Padmapping Settings"
msgstr "Tastaturbelegungseinstellungen"

Keymapper is for mouse-and-keyboard. Padmapper is for gamepad. So there needs to be two entries in the settings. The translation should differentiate between these two setups.

@StephenCWills StephenCWills changed the title [Issue Report]: dupe entry in options [Issue Report]: No differentiation between keymapper and padmapper in German translation Jul 12, 2024
@qndel
Copy link
Member

qndel commented Jul 12, 2024

Also a screenshot or a pic would've been super helpful

@AJenbo
Copy link
Member

AJenbo commented Jul 12, 2024

@Gunnar-GO are you able to provide a better translation of the two words?

@Gunnar-GO
Copy link
Author

@qndel i'm not sure if it was meant funny, but sure:
FullSizeRender

@AJenbo, uhm "Tastenbelegung" and "Controllerbelegung" or if keep an eye at the english one GamePad- / "Padbelegung" would fit to the last one also. Since the port targets doesn't have any keyboard may be it could also be hidden? (this point would fit for 3DS, vita, etc. also )

@AJenbo
Copy link
Member

AJenbo commented Jul 13, 2024

You can actually connect a keyboard to the original Xbox using a USB adapter and it will work with games that supports it.
For Vita you can use Bluetooth. The 3DS even has an official keyboard.

Would you be willing to make the corrections to the German translation: https://github.com/diasurgical/devilutionX/blob/master/Translations/de.po Then I can approve an merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants