Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve internal tests when using real images input #11

Open
schmidt9 opened this issue Oct 29, 2022 · 0 comments
Open

Improve internal tests when using real images input #11

schmidt9 opened this issue Oct 29, 2022 · 0 comments
Assignees

Comments

@schmidt9
Copy link
Contributor

Reference: #10
When testing real images from assets I was unable to achieve correct difference images comparison inside assertComparison method (commit dbdd914)

Unable to get equality between difference images #10 (comment)

I suppose (but not sure) issue may be related to some different PNG parameters of asset images and images generated with method.compareImages. Maybe before difference images comparison we should normalize them by converting to grayscale since they are both white and black, but can have different color spaces (RGB vs Grayscale)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants