Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-kit: Deprecate getRenderRemoteData #132

Open
scink opened this issue May 29, 2019 · 2 comments
Open

react-kit: Deprecate getRenderRemoteData #132

scink opened this issue May 29, 2019 · 2 comments
Labels
discussion package: react-kit

Comments

@scink
Copy link
Contributor

scink commented May 29, 2019 •
edited by sutarmin
Loading

i had a need to overwrite one of states of RenderRemoteData (RRD) that was passed within getRenderRemoteData (gRRD). but after a long offline discussion about PR expanding the model of RRD from cRRD ( #130 ) i realized, that i can use withDefaults (wD) instead of gRRD.
i believe we should use wD and deprecate gRRD
@sutarmin sutarmin changed the title createRemoteData should be deprecated react-kit: Deprecate getRenderRemoteData May 30, 2019
@devexperts devexperts deleted a comment from scink May 30, 2019
@sutarmin
Copy link
Contributor

If there were no specific reasons to create a factory and not use withDefaults in #49 then I'm ok with that. @devex-web-frontend/team any objections?

@scink
Copy link
Contributor Author

scink commented May 30, 2019

there was a reason - no one came up with using wD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion package: react-kit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sutarmin @scink