Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exposed Data Stories component #16

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Conversation

sandrahoang686
Copy link
Contributor

Related Ticket: NASA-IMPACT/veda-ui#1262
References @hanbyul-here original branch main...stories-hub

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for veda-ui-next-test ready!

Name Link
🔨 Latest commit 1eb7d5a
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui-next-test/deploys/67486b50965100000891aa4a
😎 Deploy Preview https://deploy-preview-16--veda-ui-next-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I visit the Data Catalog, I get: Application error: a client-side exception has occurred (see the browser console for more information). It doesn't seem to happen in other deployments. Could we check why?

@vgeorge
Copy link
Member

vgeorge commented Nov 28, 2024

@dzole0311 this seems to be working well for me with the current version of Veda UI in the main branch (NASA-IMPACT/veda-ui@7233df8).

The steps I followed are:

  • Set the head of my local veda-ui git repo to the commit above
  • Ran yarn buildlib on that repo
  • Changed package.json reference to my local folder ( "@developmentseed/veda-ui": "file:/Users/vgeorge/dev/veda/config/.veda/ui",)
  • Start Next.js with mbtoken set
  • Visited /data-catalog, /exploration and and /stories routes, none of them are broken

This is what I see at the stories page:

Screenshot 2024-11-28 at 12 24 08

@dzole0311
Copy link
Contributor

dzole0311 commented Nov 28, 2024

Thanks for checking @vgeorge, I also can't reproduce it locally, but the error keeps being thrown in the Netlify deployment url. I retriggered the build, but it keeps re-appearing. Looking into it.

@dzole0311
Copy link
Contributor

Strange, Netlify kept an older deployment artifact which was trying to destructure the navigate prop that we don't use anymore. I had to publish a new UI version to bust the cache (clearing the cache through Netlify didn't work).

I think this is good to go now.

@dzole0311 dzole0311 merged commit 646f516 into main Nov 28, 2024
4 checks passed
@vgeorge vgeorge deleted the add-data-stories-component branch November 28, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants