Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected test results #24

Open
micw opened this issue Apr 1, 2023 · 2 comments
Open

Add expected test results #24

micw opened this issue Apr 1, 2023 · 2 comments

Comments

@micw
Copy link

micw commented Apr 1, 2023

Hello,

IMO it would make sense to add the expected results (e.g. a list of extracted obis codes, units and values) so that this can be used to create unit tests.

@felixwrt
Copy link

felixwrt commented Apr 1, 2023

I'm not sure how the expected files should look like. I'd expect the format to heavily depend on the actual implementation and how detailed it parses the data.

In sml-rs, I tried to make the parser lossless in a sense that every attribute present in the SML spec can be accessed. I'm using debug outputs of the parsed data for my expected files. I went through them once to see whether the output makes sense. I'm using them to detect regressions now.

Here's my expected files, in case you are interested: https://github.com/felixwrt/sml-rs/tree/main/tests/snapshots

@devZer0
Copy link
Owner

devZer0 commented Apr 18, 2023

that's something that we can think about, but i have no ressources for this at the moment. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants