Skip to content

Commit

Permalink
Fix prebuilds to include ssh-wrapper
Browse files Browse the repository at this point in the history
Aside from changing `--include-regex`, I also needed to fix `prebuild` itself to support stripping debug symbols of multiple files: prebuild/prebuild#280

Instead of waiting until that PR is merged, I went ahead and switched our `prebuild` dependency with my fork, containing my changes.
  • Loading branch information
sergiou87 committed Aug 17, 2021
1 parent a2cfb8a commit cbd3dbb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
"test": "jest",
"lint": "prettier -c **/*.js **/*.md",
"lint:fix": "prettier --write **/*.js **/*.md",
"prebuild-napi-x64": "prebuild -t 3 -r napi -a x64 --strip --include-regex \"desktop-trampoline(\\.exe)?$\"",
"prebuild-napi-ia32": "prebuild -t 3 -r napi -a ia32 --strip --include-regex \"desktop-trampoline(\\.exe)?$\"",
"prebuild-napi-arm64": "prebuild -t 3 -r napi -a arm64 --strip --include-regex \"desktop-trampoline(\\.exe)?$\"",
"prebuild-napi-x64": "prebuild -t 3 -r napi -a x64 --strip --include-regex \"(desktop-trampoline|ssh-wrapper)(\\.exe)?$\"",
"prebuild-napi-ia32": "prebuild -t 3 -r napi -a ia32 --strip --include-regex \"(desktop-trampoline|ssh-wrapper)(\\.exe)?$\"",
"prebuild-napi-arm64": "prebuild -t 3 -r napi -a arm64 --strip --include-regex \"(desktop-trampoline|ssh-wrapper)(\\.exe)?$\"",
"prebuild-all": "yarn prebuild-napi-x64 && yarn prebuild-napi-ia32 && yarn prebuild-napi-arm64",
"upload": "node ./script/upload.js"
},
Expand All @@ -36,7 +36,7 @@
"devDependencies": {
"jest": "^26.4.2",
"node-gyp": "^7.1.0",
"prebuild": "^10.0.1",
"prebuild": "https://github.com/sergiou87/prebuild#strip-multiple-files",
"prettier": "^2.1.2",
"split2": "^3.2.2"
},
Expand Down
5 changes: 2 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3452,10 +3452,9 @@ prebuild-install@^6.0.0:
tar-fs "^2.0.0"
tunnel-agent "^0.6.0"

prebuild@^10.0.1:
"prebuild@https://github.com/sergiou87/prebuild#strip-multiple-files":
version "10.0.1"
resolved "https://registry.yarnpkg.com/prebuild/-/prebuild-10.0.1.tgz#9d46a00f42b60ad1718479cc5e3d1ef4882b7f33"
integrity sha512-x0CkKDmHFwX49rTGEYJwB9jBQwJWxRzwUtP5PA9dP8khFGMm3oSFgYortxdlp0PkxB29EhWGp/KQE5g+adehYg==
resolved "https://github.com/sergiou87/prebuild#d3761817d9a0db1ecf4dfbf12d02b36b0a03cadc"
dependencies:
cmake-js "~5.2.0"
detect-libc "^1.0.3"
Expand Down

0 comments on commit cbd3dbb

Please sign in to comment.