Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] about페이지 (후원사 제외) #287

Merged
merged 9 commits into from
Sep 24, 2023
Merged

Conversation

kimyouknow
Copy link
Member

@kimyouknow kimyouknow commented Sep 23, 2023

작업 내용

  • 후원사 소개를 제외한 about페이지 작업
  • 반응형 작업은 [Feat] 프로젝트 페이지네이션 + 반응형 작업 #286 여기서 sign 컴포넌트 머지되면 할게요
  • 오프라인세션 소개 컴포넌트에서 Thumbnail컴포넌트를 그대로 사용하려고 props를 추가했어요
    • showInfoDefault : 기본 상태에서 title, subTitle표시 여부
    • backgroundShow: 기본 상태에서 백그라운드에 shodow 적용여부
  • constants/footer -> contractInfo로 네이밍 수정

스크린샷

사용 방법

레퍼런스

@vercel
Copy link

vercel bot commented Sep 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 7:37am

@kimyouknow kimyouknow added the feature New feature or request label Sep 23, 2023
@github-actions github-actions bot added the style change style or request it label Sep 23, 2023
@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 78.18 KB -4.09 KB
/404 71.89 KB -4.91 KB
/_app 122.63 KB -8.29 KB
/about 75.26 KB -9.67 KB
/project 76.11 KB -18.75 KB
/recruit 108.18 KB +22.94 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@github-actions
Copy link

variants={
backgroundShow
? {
...articleVariants,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뜨헉 저 썸네일 컴포넌트 수정을 좀 많이해서 에러날것 같네요.
그런데 애니메이션이 좀 달라서 아예 프로젝트랑 세션 컴포넌트 분리해도 되겟네용ㅂ...

@depromeet-official
Copy link
Contributor

@github-actions
Copy link

@kimyouknow kimyouknow merged commit 0cb6a4b into develop Sep 24, 2023
8 of 9 checks passed
@kimyouknow kimyouknow deleted the feat/about-page branch September 24, 2023 07:36
@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request style change style or request it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants