[Feat] 프로젝트 페이지네이션 + 반응형 작업 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against d4bc7f9
|
kimyouknow
reviewed
Sep 23, 2023
| <m.span key={link.type} css={linkWrapperCss}> | ||
| <m.a href={link.href} css={linkCss} variants={textVariants}> | ||
| <span key={link.type} css={linkWrapperCss}> | ||
| <a href={link.href} css={linkCss}> |
There was a problem hiding this comment.
새로운 탭으로 열리는게 더 사용성 좋다고 생각하는데 어떻게 생각하시나요??
Suggested change
| <a href={link.href} css={linkCss}> | |
| <a href={link.href} target="_blank" css={linkCss}> |
kimyouknow
reviewed
Sep 23, 2023
Comment on lines
87
to
-74
| const sectionCss = css` | ||
| width: 100vw; | ||
| max-width: 960px; | ||
| `; |
📝 Changed routes:
Commit d9d5ff6 (https://depromeet-gmdy368fl-depromeet-official-site.vercel.app). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
스크린샷
PC
태블릿
모바일
사용 방법
레퍼런스