[Feat] main 페이지 디자인 구현 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pages/index.tsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against d4bc7f9
|
스토리북으로 확인했을 때는 잘 모르겠는데 어떤 이슈예요?? |
99-zziy
reviewed
Sep 22, 2023
| @@ -65,4 +66,8 @@ const tabCss = (theme: Theme, isActive: boolean) => css` | |||
| color: ${isActive ? theme.colors.yellow500 : theme.colors.white}; | |||
| cursor: pointer; | |||
| padding: 16px 24px; | |||
|
|
|||
| ${mediaQuery('mobile')} { | |||
| font-size: 14px; | |||
There was a problem hiding this comment.
rem 이나 윤호님이 만들어주신 typo 사용하면 좋을 것 같아요 !
There was a problem hiding this comment.
이부분은 다른 부분에서도 이런식으로 사용해서, 다른 브랜치에서 한번에 바꾸겠습니다!
99-zziy
approved these changes
Sep 22, 2023
다시 시도해보니 안뜨네요,./? 또 같은 현상을 발견하면 그때 다시 말씀드리겠습니다! |
# Conflicts: # src/pages/index.tsx
* style: gnb pc design 수정 * feat: mobile menu icon 추가 * refactor: pc footer theme 적용 * style: footer 모바일 반응형 추가 --------- Co-authored-by: byun sumi <sumi@adenasoft.com>
# Conflicts: # src/components/SectionTitle/SectionTitle.tsx
📝 Changed routes:
Commit 1bbf8a5 (https://depromeet-7ooa1ef2q-depromeet-official-site.vercel.app). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
main 디자인 PC, Mobile 남은 부분 작업
main에서만 사용하는 컴포넌트는
components/Main으로 옮겼습니다. (스토리북 추가 예정)FAQ 반응형 작업
스크린샷