Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] breakpoint theme 추가 #273

Merged
merged 3 commits into from
Sep 17, 2023
Merged

[Feat] breakpoint theme 추가 #273

merged 3 commits into from
Sep 17, 2023

Conversation

sumi-0011
Copy link
Member

작업 내용

  • 반응형 작업을 위한 breakpoint를 theme에 추가했어요.
  • Button 컴포넌트 모바일 반응형을 추가했어요.

@vercel
Copy link

vercel bot commented Sep 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 2:07pm

@sumi-0011 sumi-0011 added the feature New feature or request label Sep 17, 2023
@github-actions github-actions bot added style change style or request it workflow Change for workflow and removed feature New feature or request labels Sep 17, 2023
@sumi-0011 sumi-0011 changed the base branch from main to develop September 17, 2023 11:10
@sumi-0011 sumi-0011 changed the base branch from develop to fix/button-size September 17, 2023 11:11
@github-actions
Copy link

github-actions bot commented Sep 17, 2023 •
edited
Loading

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 72.18 KB -10.08 KB
/404 71.89 KB -4.91 KB
/_app 115.15 KB -15.76 KB
/about 72.2 KB -12.73 KB
/project 72.2 KB -22.66 KB
/recruit 72.2 KB -13.04 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@github-actions
Copy link

🚀storybook: https://650537b463234bd00676edec-dqqvbzansd.chromatic.com/

kimyouknow
kimyouknow reviewed Sep 17, 2023
View reviewed changes
Copy link
Member

@kimyouknow kimyouknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

media query 이전 기수 코드 참고해서

  ${mediaQuery('xs')} {
    height: 200px;
  }

이런식으로 하는 건 어때요??

@kimyouknow kimyouknow mentioned this pull request Sep 17, 2023
Merged
99-zziy
99-zziy reviewed Sep 17, 2023
View reviewed changes
src/components/Button/Button.tsx Outdated
`}

${size === 'lg' &&
css`
width: 100%;
padding: 0 24px;
height: 54px;

@media screen and (max-width: ${theme.breakpoints.mobile}) {
Copy link
Member

@99-zziy 99-zziy Sep 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 기수 웹 사이트 코드에서 봤는데
요거 참고해서 만들어두면 좀 더 가독성 좋을것 같아요 !

@github-actions github-actions bot removed the workflow Change for workflow label Sep 17, 2023
kimyouknow
kimyouknow approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@kimyouknow kimyouknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sumi-0011 sumi-0011 merged commit 2994605 into fix/button-size Sep 17, 2023
9 checks passed
@sumi-0011 sumi-0011 deleted the feat/breakpoint branch September 17, 2023 14:11
sumi-0011 added a commit that referenced this pull request Sep 17, 2023
@sumi-0011
[Feat] 버튼 컴포넌트 수정 (#276)
6c42318 
* feat: 버튼 사이즈 추가, disabled 추가

* feat: active hover 상태 추가

* fix: disabled 순서 변경

* [Feat] breakpoint theme 추가 (#273)

* feat: breakpoint add

* feat: mobile button 추가

* feat: media query 이전 기수 처럼 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimyouknow kimyouknow kimyouknow approved these changes

@99-zziy 99-zziy 99-zziy approved these changes

Assignees

@sumi-0011 sumi-0011

Labels
style change style or request it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumi-0011 @99-zziy @kimyouknow