Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 버튼 컴포넌트 수정 #272

Closed
wants to merge 22 commits into from
Closed

[Feat] 버튼 컴포넌트 수정 #272

wants to merge 22 commits into from

Conversation

sumi-0011
Copy link
Member

작업 내용

  • Button 컴포넌트에 size, disabled, hover, active 상태를 추가하였습니다.
  • 이외에 버튼 마다 따로 주어야하는 css를 대응하기 위해 overrideCss props를 추가했습니다.

스크린샷

스크린샷 2023-09-17 오후 7 52 29

사용 방법

<Button>지원하기</Button>
<Button disabled>지원하기</Button>
<Button size="lg">지원하기</Button>
<Button size="lg" disabled>
  지원하기
</Button>

99-zziy and others added 22 commits September 9, 2023 15:41
@99-zziy
feat: 14기 웹사이트 초기세팅
77ed10f
@99-zziy
fix: export 추가
2f8745d
@99-zziy
chore: 사용안하는 asset 삭제
8e17bcd
@kimyouknow
[chore] storybook (^7.4.0) 설치 (#250)
8012761 
* chore: install storybook(^7.4.0)

* feat: faq storybook test component
@kimyouknow
[Feat] Icon 컴포넌트 세팅 & storybook emotion 설정 (#251)
d009b8d 
* chore: storybook emotion 설정

- storybookjs/storybook#7540

* feat: svg wrapper component

* feat: arrow icon
@kimyouknow
[Chore] Emotion theme 세팅 (#252)
93142ee 
* feat: emotion theme

* feat: emotion faq example

* feat: typo theme

* refactor: typo에 pxToRem() 적용
@99-zziy
[Feat] 버튼 컴포넌트, GNB, Footer 추가 (#253)
5905a6d 
* refactor: 화살표 함수에서 function으로 수정

* feat: global cursor style 삭제

* feat: gnb 추가

* feat: button 추가

* feat: gnb 스타일 추가

* feat: 해당하는 페이지의 버튼 링크 색 변경

* feat: footer 추가

* refactor: function, named export

* feat: footer style 수정
@kimyouknow
[feat] FAQ 컴포넌트 (#255)
9947e15 
* chore: storybook emotion 설정

- storybookjs/storybook#7540

* feat: svg wrapper component

* feat: arrow icon

* feat: typo theme

* feat: emotion theme

* feat: emotion faq example

* feat: emotion theme

* feat: emotion faq example

* feat: typo theme

* chore: vscode typescript 버전 세팅

* chore: rename FAQ -> FAQItem

* feat: create FAQList

* feat: create FAQList story

* feat: li list style none

* chore: mock 데이터 위치 수정
@kimyouknow
[feat]: typo 변경 사항 반영 (#261)
634ba32 
feat: typo 변경 사항 반영
@kimyouknow @sumi-0011
[Feat] section title 컴포넌트 (#257)
0b0f9a1 
* feat: section title component

* feat: decimal font apply

* feat: member schedule section

* feat: title bg color add and storybook add

* [Fix] section title 엔터 안먹는 문제 수정 (#258)

fix: section title no enter fix

* feat: unused style css

* feat: section title css 수정 사항 반영

- 폰트 속성

* feat: yellow -> yellow500

---------

Co-authored-by: byun sumi <sumi@adenasoft.com>
Co-authored-by: sumi.byun <selina2000@naver.com>
@kimyouknow
[Feat] auto carousel with Swiper && 지난 기수 후기 컴포넌트 (#256)
332b088 
* chore: swiper

* chore: remove react-responsive-carousel

* feat: swiper with auto infinite carousel

* feat: create review component

* feat: 디자인 수정 반영

* feat: auto carousel 반복 안되는 에러 수정
@kimyouknow
[Chore] chromatic 세팅 (#262)
41879da 
* chore: chromatic

* chore: set chromatic github action script
@sumi-0011 @kimyouknow
[Feat] 모집 일정 컴포넌트 (#259)
a230387 
* feat: section title component

* feat: decimal font apply

* feat: member schedule section

* feat: title bg color add and storybook add

* Update src/components/ScheduleSection/ScheduleSection.tsx

Co-authored-by: 김윤호 yunho <kimyouknow@naver.com>

---------

Co-authored-by: yunho <kimyouknow@naver.com>
Co-authored-by: byun sumi <sumi@adenasoft.com>
@99-zziy
[Feat] thumbnail(프로젝트, 세션) 컴포넌트 (#265)
e3ef25f 
* chore: storybook next image 설정

* feat: 썸네일 컴포넌트 개발

* feat: app.tsx에서 썸네일 컴포넌트 삭제
@kimyouknow
[Feat] 전체지원자격 컴포넌트 (#263)
ee9c83a 
* feat: formatSingleDigit

* feat: create Qualification

* chore: chromatic id 추가
@kimyouknow
[Feat] 모집직군 컴포넌트 (#264)
0caa195 
* chore: position icon image

* chore: storybook static

* feat: 이미지 경로 상수화

* feat: create Positions
@kimyouknow
[chore] stroybook public 중복 설정 제거 (#267)
0eb2352 
chore: 중복 설정 제거
@99-zziy
feat: 표지판 이미지 컴포넌트 개발
e4f8850
@sumi-0011
[Fix] GNB 공간 채움 (#266)
fa705e0
@sumi-0011
feat: 버튼 사이즈 추가, disabled 추가
8c8beae
@sumi-0011
feat: active hover 상태 추가
1ab0436
@sumi-0011
fix: disabled 순서 변경
c003c21
@vercel
Copy link

vercel bot commented Sep 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 10:53am

@sumi-0011 sumi-0011 added the feature New feature or request label Sep 17, 2023
@github-actions github-actions bot added style change style or request it workflow Change for workflow labels Sep 17, 2023
@github-actions
Copy link

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 72.18 KB -10.08 KB
/404 71.89 KB -4.91 KB
/_app 115.02 KB -15.89 KB
/about 72.2 KB -12.73 KB
/project 72.2 KB -22.66 KB
/recruit 72.2 KB -13.04 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@github-actions
Copy link

🚀storybook: https://650537b463234bd00676edec-ajfefynztu.chromatic.com/

@kimyouknow
Copy link
Member

수미님 이거 main말고 develop으로 해주세요!

@kimyouknow kimyouknow closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimyouknow kimyouknow Awaiting requested review from kimyouknow

@99-zziy 99-zziy Awaiting requested review from 99-zziy

Assignees

@sumi-0011 sumi-0011

Labels
feature New feature or request style change style or request it workflow Change for workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumi-0011 @kimyouknow @99-zziy