Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: global layout #269

Merged
merged 1 commit into from
Sep 17, 2023
Merged

[feat]: global layout #269

merged 1 commit into from
Sep 17, 2023

Conversation

kimyouknow
Copy link
Member

작업 내용

global layout 용 css 개발

  • [지난 기수 후기] 처럼 페이지 width 전체를 사용해야하는 컴포넌트도 있어서 페이지에 commonLayoutCss를 주기보다 컴포넌트마다 주는 게 좋을 것 같아요

스크린샷

사용 방법

아래처럼 필요한 컴포넌트 마다 override해서 사용하시면 돼요!

const layoutCss = css`
  ${commonLayoutCss}
  display: flex;
  flex-direction: column;
  align-items: center;
`;

레퍼런스

@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 8:59am

@kimyouknow kimyouknow added the feature New feature or request label Sep 17, 2023
@github-actions github-actions bot added the style change style or request it label Sep 17, 2023
@github-actions
Copy link

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 72.18 KB -10.08 KB
/404 71.89 KB -4.91 KB
/_app 114.81 KB -16.1 KB
/about 72.2 KB -12.73 KB
/project 72.2 KB -22.66 KB
/recruit 72.2 KB -13.04 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@kimyouknow kimyouknow changed the title feat: global layout [feat]: global layout Sep 17, 2023
@github-actions
Copy link

Copy link
Member

@sumi-0011 sumi-0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 👍🏻

@kimyouknow kimyouknow merged commit 1dce019 into develop Sep 17, 2023
10 checks passed
@kimyouknow kimyouknow deleted the feat/global-layout branch September 17, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request style change style or request it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants