Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] GNB 공간 채움 #266

Merged
merged 1 commit into from
Sep 17, 2023
Merged

[Fix] GNB 공간 채움 #266

merged 1 commit into from
Sep 17, 2023

Conversation

sumi-0011
Copy link
Member

작업 내용

  • main 화면을 제작 중 GNB와 Footer가 겹치는 현상을 확인하고, GNB의 position이 fixed로 되어있어 발생하는 문제인 것을 확인하였습니다.
  • GNB가 화면의 top에 유지되어야하기 때문에 position:fixed는 유지하고, 그 만큼의 공간을 차지하게 하기 위해 빈 div를 생성하여 채워주었습니다.

스크린샷

스크린샷 2023-09-17 오후 3 11 12

스크린샷 2023-09-17 오후 3 10 56

@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview Sep 17, 2023 6:12am

@sumi-0011 sumi-0011 changed the base branch from main to develop September 17, 2023 06:12
@github-actions
Copy link

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 72.18 KB -10.08 KB
/404 71.89 KB -4.91 KB
/_app 114.73 KB -16.18 KB
/about 72.2 KB -12.73 KB
/project 72.2 KB -22.66 KB
/recruit 72.2 KB -13.04 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@github-actions
Copy link

🚀storybook:

@kimyouknow
Copy link
Member

굳굳!

@sumi-0011 sumi-0011 merged commit fa705e0 into develop Sep 17, 2023
10 checks passed
@sumi-0011 sumi-0011 deleted the fix/GNB-blank branch September 17, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants