[Feat] 버튼 컴포넌트, GNB, Footer 추가 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
윤호님이 설정해주신 storybook, theme merge 하면 다시 수정해서 PR하겠습니다 👀.. |
Bundle SizesCompared against d4bc7f9
|
kimyouknow
approved these changes
Sep 10, 2023
src/components/Button/Button.tsx
Outdated
|
|
||
| export type ButtonProps = ButtonHTMLAttributes<HTMLButtonElement> & PropsWithChildren; | ||
|
|
||
| export const Button = ({ children, ...props }: ButtonProps) => { |
There was a problem hiding this comment.
function 컴포넌트로 통일...ㅎㅎㅎㅎㅎㅎㅎㅎ
src/components/Button/index.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export * from './Button'; | |||
There was a problem hiding this comment.
이렇게하면 default export아닌가요? 아래처럼해야 named export로 알고 있는뎁
Suggested change
| export * from './Button'; | |
| export { Button } from './Button'; |
| @@ -27,8 +27,6 @@ const globalCss = css` | |||
| box-sizing: border-box; | |||
| word-break: keep-all; | |||
| word-wrap: break-word; | |||
|
|
|||
| cursor: none !important; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
스크린샷
사용 방법
레퍼런스