[FEAT/#45] Argument 친구 목록 재사용 추가 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/#24-moimcreate-ui # Conflicts: # core/data/src/main/java/com/teumteum/data/repository/UserRepositoryImpl.kt # core/data/src/main/java/com/teumteum/data/service/UserService.kt # core/domain/src/main/java/com/teumteum/domain/repository/UserRepository.kt
unam98
approved these changes
Jan 23, 2024
| val userInfoState by viewModel.userInfoState.collectAsState() | ||
|
|
||
| val topbarText = when (val state = userInfoState) { | ||
| is UserInfoUiState.Success -> "${state.data.name}의 소개서" |
There was a problem hiding this comment.
이 부분 스트링 리소스로 빼면 좋을 것 같아요!
Comment on lines
+45
to
+48
| viewModel.loadFriendInfo(userId.toLong()) | ||
| viewModel.getUserOpenMeeting(userId.toLong()) | ||
| viewModel.getUserClosedMeeting(userId.toLong()) | ||
| viewModel.loadFriends(userId.toLong()) |
There was a problem hiding this comment.
run 쓰면 더 깔끔해질 수 있을 것 같아요~!
There was a problem hiding this comment.
저도 같은걸 두번씩 써야하나 싶었는데 run이 있었군요 🫡 감삼다
| if (userId != -1L) { | ||
| viewModelScope.launch { | ||
| settingRepository.getMyPageOpenMeeting(userId) | ||
| .onSuccess { meetings -> |
There was a problem hiding this comment.
여기 "mettings"는 쓰이는 곳이 없는 것 같은데 맞나요?
There was a problem hiding this comment.
아하 정답이네용 왜냐면 이전에 했던걸 긁어온건데 거기랑 돌아오는 result 값이 달랐거든요 . . .수정하도록 하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
📸 스크린샷/동영상