[BSVR-103] 야구 팀(구단) 등록 & 조회 API #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjiShin
commented
Jul 14, 2024
Comment on lines
+54
to
+56
| private boolean isNullOrBlank(String str) { | ||
| return str == null || str.isBlank(); | ||
| } |
There was a problem hiding this comment.
요거 여기저기서 많이 쓸 것 같아서, 나중에 StringUtils 같은 유틸 클래스로 뽑으려고!
EunjiShin
commented
Jul 14, 2024
There was a problem hiding this comment.
JPA에서 Auto Increment ID 방식을 사용할 때 bulk insert가 불가능하다는 문제를 보완하기 위해 JDBC template 이용했어~
단점) string으로 raw query를 그대로 작성하기 때문에, 쿼리에 문제가 있다면 런타임 중 에러가 발생할 수 있음. 테스트 필수!
EunjiShin
commented
Jul 14, 2024
Comment on lines
+71
to
+74
| @Override | ||
| public boolean existsByNameIn(List<String> names) { | ||
| return baseballTeamJpaRepository.existsByNameIn(names); | ||
| } |
There was a problem hiding this comment.
in 쿼리를 사용해서 bulk insert 중 중복 구단명이 하나라도 있다면 예외를 반환하게 처리했어.
[ 참고! ]
mysql에서 in 쿼리는 인자 수가 엄청나게 많아지면 인덱스를 타지 못한다는 성능 이슈가 있어.
우리 서비스에서 등록하는 구단 수는 10개고, 구단 등록 API는 어드민 API라서 위 성능 이슈가 운영 환경에서 발생하진 않을거라고 생각해! 하지만 이슈 인지하고 있는게 좋을 것 같아서 레퍼런스 첨부해둘게~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요 (필수)
🔨 작업 사항 (필수)
🌱 연관 내용 (선택)
💻 실행 화면 (필수)
생성 후 조회 API call 결과
