[BSVR-63] custom exception & global exception handler 추가 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjiShin
commented
Jul 5, 2024
|
|
||
| import org.springframework.http.HttpStatus; | ||
|
|
||
| public interface ErrorCode { |
There was a problem hiding this comment.
모든 도메인의 errorCode가 하나의 enum class에서 관리되면, 클래스가 너무 커져서 관리하기 힘들거라고 생각했어요.
(e.g., 200개의 error code 중에서 member와 관련된 error들을 찾는 상상..)
따라서 공통 포맷을 인터페이스로 만들고, 도메인별로 errorCode를 구현하게 처리해 응집도를 높였어요.
EunjiShin
commented
Jul 5, 2024
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public enum MemberErrorCode implements ErrorCode { |
There was a problem hiding this comment.
custom error를 만들어야 한다면, 이런식으로 ErrorCode를 구현하는 enum 클래스를 새로 생성하면 돼요.
EunjiShin
commented
Jul 5, 2024
Comment on lines
+23
to
+26
| public MemberErrorCode appended(Object o) { | ||
| message = message + " {" + o.toString() + "}"; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
정해진 메세지 외에 추가로 정보를 제공하고 싶을 수 있어요. 그때 사용하는 메서드에요.
EunjiShin
commented
Jul 5, 2024
Comment on lines
+12
to
+18
| public MemberNotFoundException() { | ||
| super(MemberErrorCode.MEMBER_NOT_FOUND); | ||
| } | ||
|
|
||
| public MemberNotFoundException(Object o) { | ||
| super(MemberErrorCode.MEMBER_NOT_FOUND.appended(o)); | ||
| } |
There was a problem hiding this comment.
단순 예시..!
no args constructor를 사용하면 enum code에 지정해둔 message가 할당될 것이고,
appended() 메서드를 활용하면 원하는 정보를 추가로 전달할 수 있어요.
(e.g., 특정 name에 해당하는 유저가 없을 경우, name : {string}을 message에 추가하는 등)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요 (필수)
🔨 작업 사항 (필수)
🌱 연관 내용 (선택)
💻 실행 화면 (필수)