Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat windows settings catalog v3 #177

Merged
merged 19 commits into from
Nov 13, 2024
Merged

Conversation

ShocOne
Copy link
Contributor

@ShocOne ShocOne commented Nov 13, 2024

Change

changed approach for handling settings catalog by using a var for a json struct and refactoring approach for hcl setting catalog setting config to now use json. also discovered a way to correctly output json definition of requests.

Type of Change

  • Refactor of existing code

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

ShocOne and others added 19 commits November 12, 2024 13:44
@ShocOne ShocOne merged commit e9157a7 into main Nov 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant