updates to stating

internal/resources/devicemanagement/beta/assignmentFilters/object.go

@@ -2,6 +2,7 @@ package assignmentFilter
 
 import (
 	"fmt"
+
 	"github.com/hashicorp/terraform-plugin-framework/types"
 
 	"github.com/microsoftgraph/msgraph-beta-sdk-go/models"

internal/resources/devicemanagement/beta/assignmentFilters/resource.go

@@ -171,7 +171,6 @@ func (r *AssignmentFilterResource) Create(ctx context.Context, req resource.Crea
 	tflog.Debug(ctx, fmt.Sprintf("Finished creation of resource: %s_%s", r.ProviderTypeName, r.TypeName))
 }
 
-// Read handles the Read operation.
 func (r *AssignmentFilterResource) Read(ctx context.Context, req resource.ReadRequest, resp *resource.ReadResponse) {
 	ctx, cancel := context.WithTimeout(ctx, 1*time.Minute)
 	defer cancel()
@@ -194,18 +193,7 @@ func (r *AssignmentFilterResource) Read(ctx context.Context, req resource.ReadRe
 		return
 	}
 
-	data.DisplayName = types.StringValue(*filter.GetDisplayName())
-	data.Description = types.StringValue(*filter.GetDescription())
-	platformStr, err := DevicePlatformTypeToString(filter.GetPlatform())
-	if err != nil {
-		resp.Diagnostics.AddError(
-			"Error reading assignment filter",
-			fmt.Sprintf("Could not convert platform: %s", err.Error()),
-		)
-		return
-	}
-	data.Platform = types.StringValue(platformStr)
-	data.Rule = types.StringValue(*filter.GetRule())
+	setTerraformState(&data, filter, resp)
 
 	tflog.Debug(ctx, fmt.Sprintf("READ: %s_environment with id %s", r.ProviderTypeName, data.ID.ValueString()))
 

internal/resources/devicemanagement/beta/assignmentFilters/state.go

@@ -0,0 +1,33 @@
+package assignmentFilter
+
+import (
+	"github.com/hashicorp/terraform-plugin-framework/attr"
+	"github.com/hashicorp/terraform-plugin-framework/resource"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/microsoftgraph/msgraph-beta-sdk-go/models"
+)
+
+func setTerraformState(data *AssignmentFilterResourceModel, filter models.DeviceAndAppManagementAssignmentFilterable, resp *resource.ReadResponse) {
+	data.DisplayName = types.StringValue(*filter.GetDisplayName())
+	data.Description = types.StringValue(*filter.GetDescription())
+	data.Platform = types.StringValue(filter.GetPlatform().String())
+	data.Rule = types.StringValue(*filter.GetRule())
+	data.AssignmentFilterManagementType = types.StringValue(filter.GetAssignmentFilterManagementType().String())
+	data.CreatedDateTime = types.StringValue(filter.GetCreatedDateTime().String())
+	data.LastModifiedDateTime = types.StringValue(filter.GetLastModifiedDateTime().String())
+
+	// Set RoleScopeTags
+	roleScopeTags := filter.GetRoleScopeTags()
+	if roleScopeTags != nil {
+		tagList := make([]attr.Value, len(roleScopeTags))
+		for i, tag := range roleScopeTags {
+			tagList[i] = types.StringValue(tag)
+		}
+		roleScopeTagsList := types.ListValueMust(types.StringType, tagList)
+		data.RoleScopeTags = roleScopeTagsList
+	} else {
+		roleScopeTagsList := types.ListValueMust(types.StringType, []attr.Value{})
+		data.RoleScopeTags = roleScopeTagsList
+	}
+
+}