Send VA Profile data on SMS Notification Delivery status

[MackHalliday]

User Story - Business Need

VA Profile is interested in tracking SMS delivery status so that they might offer data to their partners regarding the quality of contact data/the likelihood of delivery success. VA Notify needs to send VA Profile the delivery status of ALL SMS notifications so VA Profile can track this information.

It is recommended to reuse the code created in #1770 to send VAProfile Email Notification statues. check_and_queue_va_profile_email_status_callback and it's childern method could be updated to be notification-type ambiguous, handling both SMS and Email notification types. check_and_queue_callback_task can also be modified to capture the status of all SMS Notifications and send them to VAProfile.

• Ticket is understood, and QA has been contacted (if the ticket has a QA label).
• Touch base with Cris when she is back.

User Story(ies)

As a developer on the VA Notify team
I want to send real-time SMS delivery status updates to VA Profile
So that the VA system can improve the management and reliability of contact data, thereby enhancing communication with veterans and maintaining the organization's contact reputation.

Additional Info and Resources

• Send VA Profile data on Email Notification Delivery status #1770 - Prior Work completed for sending Email Notification status
• check_and_queue_callback_task could be updated to send the status of all SMS Notifications to VAProfile.
• check_and_queue_va_profile_email_status_callback - Can be updated to be notification-type ambiguous and send notification status to VAProfile

Acceptance Criteria

• When ANY SMS or email delivery status is processed, it should trigger a POST request to VA Profile with accurate and complete delivery status data in the DEV/PERF environments.
• Delivery status data prior to the delivery attempt should NOT trigger a POST request to VA Profile
• The system should handle errors gracefully and log them appropriately
• The feature should work seamlessly with existing infrastructure, with minimal need for new development.
• All changes should be well-documented
• This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

• Verify that a delivery status triggers the POST request to VA Profile. This probably requires checking the logs. Work with developer to understand the logging.
• Verify the feature flag and parameters
• Take a look at the documentation.

Potential Dependencies

VA Profile's Pilot will happen next PI (starting mid-December), most likely wait until the new year.

[MackHalliday]

Notes from Conversation with Kyle

1. How should the feature flag be handled?

• Repurpose VA_PROFILE_EMAIL_STATUS_ENABLED

2. Should this be implemented in the check_and_queue_callback_task function?

• Better to handle under sms_status_update under if last_updated_at != notification.updated_at

3. AC Delivery status data prior to the delivery attempt should NOT trigger a POST request to VA Profile. What status are considered pre-delivery?
   See notification-api/app/constants.py

Will touch base with @cris-oddball when she's back on Monday.

[MackHalliday]

Yesterday

• Spoke to Kyle regarding implementation (See notes above)
• Create initial test for sending SMS to VAProfile
• Refactor send_email_status_to_va_profile to handle SMS

Today

• Rename and move send_email_status_to_va_profile to own module
• Fix tests that will break

I'm out on Friday. So I'll leave an update at the EOD