Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Twilio Error Code 30500 #2104

Open
5 tasks
k-macmillan opened this issue Nov 5, 2024 · 0 comments
Open
5 tasks

Handle Twilio Error Code 30500 #2104

k-macmillan opened this issue Nov 5, 2024 · 0 comments

Comments

@k-macmillan
Copy link
Member

k-macmillan commented Nov 5, 2024

User Story - Business Need

30500 is a Twilio internal error, and we should mark the notification as temporary-failure.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify client
I want my notification updates to be as accurate as possible
So that I can make informed decisions

Additional Info and Resources

The _evaluate_status method controls this behavior. This error code is not mapped, so it fell to a technical error. Add the mapping below to the twilio client twilio_error_code_map. There are too many Twilio statuses to effectively map, so we have to deal with them as we find them.

New constant for retryable:

    RETRYABLE_STATUS_REASON = 'Retryable - Notification is unable to be processed at this time. Replay the request to VA Notify.'
    '30500': TwilioStatus(30500, NOTIFICATION_TEMPORARY_FAILURE, RETRYABLE_STATUS_REASON),

Acceptance Criteria

  • New constant added for retries in constants.py, listed in additional information
  • 30500 is added as a temporary-failure status with a message matching the additional information section
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

  • Get an appropriately signed test body from the developer to be able to add this to the lambda testing. then test it.

Potential Dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants