BUG: Unhandled exception

[k-macmillan]

Description

The system is capturing a NotificationPermanentFailureException as an "unhandled" exception. It is handled but incorrectly falling through to the generic catch.

• Ticket is understood, and QA has been contacted (if the ticket has a QA label).
• This work is added to the sprint review slide deck (key win bullet point and demo slide)

Steps to Reproduce

1. Find a test individual that can be modified
2. Set their preference for a communication item and channel to false so that it the bio returns allowed=False
3. Send a notification and observe the logs

The notification is updated, no workaround is required.

Impact/Urgency

Low. This is to help clean up our logging to make sure only actual errors are reported.

Expected Behavior

• We do not log an expected outcome as an error
• The expected exception does not fall to the generic catch

QA Considerations

The regression sends notifications to recipients that disallow communication items on templates that have those communication items. Check the logs after the regression runs to see that the AC above is met.

Additional Info & Resources

• Logs of one of the failures
• "Unhandled exception for notification" is in code in two locations (searchable)
• Example that can be seen in Perf (2350b837-fb74-4078-bc4d-c7762a7f5ff1 on Oct 10, 2024 at 3:27:34.777 am Eastern)