Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate to any address #162

Open
Tbaut opened this issue Sep 24, 2024 · 4 comments
Open

Delegate to any address #162

Tbaut opened this issue Sep 24, 2024 · 4 comments
Labels
Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. Type: 🏗️ Feature Added to issues and PRs to identify that the change is a new feature.

Comments

@Tbaut
Copy link
Contributor

Tbaut commented Sep 24, 2024

Feature request from a user:
I want to delegate to any address, and not just from the ones in the list.

Personal opinion: It's a feature request I expected to come eventually. We need to think about it in terms of design. Maybe a button in front of the list? Also we need to adapt the Delegate/index.tsx to not error out if the address isn't known.

@Tbaut Tbaut added Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. Type: 🏗️ Feature Added to issues and PRs to identify that the change is a new feature. labels Sep 24, 2024
@Tbaut
Copy link
Contributor Author

Tbaut commented Oct 3, 2024

in terms of design, I'm thinking of:
An input above the list to:

  • search/filter the delegate list by name/address
  • show a Delegate button/link if there's no delegate found to redirect to the delegate page with this address the user pasted. We just need to check it's a valid address.

@uDaiko
Copy link
Contributor

uDaiko commented Oct 10, 2024

Aside from search/redirect functionality, the current validation against the registry would need to be changed it seems. I'll have a look. Could you assign me?

@Tbaut
Copy link
Contributor Author

Tbaut commented Oct 10, 2024

Hey @uDaiko thank you so much for your help. I would prefer if you pick another one as it's far from being an easy one tbh and the design may be tricky to get right. I'd suggest to pick for instance something like #125

@uDaiko
Copy link
Contributor

uDaiko commented Oct 12, 2024

@Tbaut sure no problem. I'll check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. Type: 🏗️ Feature Added to issues and PRs to identify that the change is a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants