Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single and double quotes get formatted differently in Groovy queries #2236

Open
jjbrosnan opened this issue Sep 26, 2024 · 1 comment
Open
Labels
bug Something isn't working
Milestone

Comments

@jjbrosnan
Copy link

When I write Groovy queries, single-quoted strings are colored yellow. Double-quoted are colored white. This is an issue particularly in docs, where we use double-quoted strings everywhere. In docs, they're formatted yellow. A user who copy/pastes Groovy code into the web IDE will have a tougher time figuring out which text is in a string and which is not.

It would be nice if they were both yellow, even though they're technically different according to the Groovy interpreter.

@jjbrosnan jjbrosnan added the bug Something isn't working label Sep 26, 2024
@mattrunyon
Copy link
Collaborator

https://github.com/deephaven/web-client-ui/blob/main/packages/console/src/monaco/lang/groovy.ts#L151 is the offending line. If we want both as strings we should remove this clause. If we want both as "deephavenDb" (which doesn't seem to actually colorize anything), we should add single quotes to this clause

@mattrunyon mattrunyon added the triage Issue requires triage label Sep 26, 2024
@mattrunyon mattrunyon changed the title SIngle and double quotes get formatted differently in Groovy queries Single and double quotes get formatted differently in Groovy queries Sep 26, 2024
@vbabich vbabich added this to the October 2024 milestone Oct 1, 2024
@vbabich vbabich removed the triage Issue requires triage label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants