You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While fixing deephaven/deephaven-core#6067 I found that it appears IrisGridModelUpdater is applying sort, filter, viewport, then closing the current rollup to replace it with a new one.
Steps to reproduce:
Check out 6067-treetable-race from github.com/niloc132/deephaven-core. This branch has extra logging turned on
Expected: log should show that the old rollup is closed, new rollup happens, sorts/filters are applied
Actual: old rollup is filtered, sorted, subscribed, then closed, and then a new rollup is created, sorted/filters, subscribed.
In this example log, 17 is the old rollup table being closed, and 18 is the new one being created.
The "TreeTable already closed" lines can be ignored, they're a side effect of closing while operations are pending. Likewise the application of the same filter/sort repeatedly should have no effect and shouldn't re-create the subscription, but that'll be fixed with the rest of 6067.
The text was updated successfully, but these errors were encountered:
While fixing deephaven/deephaven-core#6067 I found that it appears IrisGridModelUpdater is applying sort, filter, viewport, then closing the current rollup to replace it with a new one.
Steps to reproduce:
Expected: log should show that the old rollup is closed, new rollup happens, sorts/filters are applied
Actual: old rollup is filtered, sorted, subscribed, then closed, and then a new rollup is created, sorted/filters, subscribed.
In this example log,
17
is the old rollup table being closed, and18
is the new one being created.The "TreeTable already closed" lines can be ignored, they're a side effect of closing while operations are pending. Likewise the application of the same filter/sort repeatedly should have no effect and shouldn't re-create the subscription, but that'll be fixed with the rest of 6067.
The text was updated successfully, but these errors were encountered: