Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeTable has operations applied to it immediately before close #2221

Open
niloc132 opened this issue Sep 13, 2024 · 0 comments
Open

TreeTable has operations applied to it immediately before close #2221

niloc132 opened this issue Sep 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@niloc132
Copy link
Member

While fixing deephaven/deephaven-core#6067 I found that it appears IrisGridModelUpdater is applying sort, filter, viewport, then closing the current rollup to replace it with a new one.

Steps to reproduce:

  1. Check out 6067-treetable-race from github.com/niloc132/deephaven-core. This branch has extra logging turned on
  2. Create a table, such as
    from deephaven import empty_table
    t = empty_table(1000).update(["X=i%2", "Y=i%5", "Z=i"])
  3. Open the menu at the upper right, select Rollup
  4. Double-click X, then double-click Y
  5. With the browser console open, remove X

Expected: log should show that the old rollup is closed, new rollup happens, sorts/filters are applied

Actual: old rollup is filtered, sorted, subscribed, then closed, and then a new rollup is created, sorted/filters, subscribed.

In this example log, 17 is the old rollup table being closed, and 18 is the new one being created.
screenshot919

The "TreeTable already closed" lines can be ignored, they're a side effect of closing while operations are pending. Likewise the application of the same filter/sort repeatedly should have no effect and shouldn't re-create the subscription, but that'll be fixed with the rest of 6067.

@niloc132 niloc132 added the bug Something isn't working label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant