fix: Disposal Logic + Error toast #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bmingles
commented
Nov 13, 2024
•
bmingles
commented
- Cleanup panel caches on server disconnect. Should resolve Panel list does not reflect the current server state #145
- Added a toast when running a script for the first time auto connects to a server that doesn't support the language. Part of Attempting to run a groovy file in python results in a disconnect #97
- Map value disposal
- Event handler disposal
- Fixed circular dependencies issue between services and util folders. Services can now depend on utils. Utils should not depend on services.
End-to-end Test Summary
Detailed Test Results
Failed Test SummaryNo failed tests ✨Flaky Test SummaryNo flaky tests detected. ✨ |
bmingles
changed the title
bmingles
force-pushed
the
152-connection-cleanup
branch
from
0e927b0
to
9603cf9
Compare
bmingles
commented
Nov 13, 2024
| @@ -382,6 +404,7 @@ export class ExtensionController implements Disposable { | |||
|
|
|||
| this._serverManager.onDidDisconnect( | |||
| serverUrl => { | |||
| this._panelService?.clearServerData(serverUrl); | |||
bmingles
commented
Nov 13, 2024
src/services/PollingService.spec.ts
Outdated
There was a problem hiding this comment.
Moved out of utils
bmingles
commented
Nov 13, 2024
| * @returns Promise that resolves when the poll function returns true + a `reject` | ||
| * function that can be used to cancel the polling. | ||
| */ | ||
| export function pollUntilTrue( |
There was a problem hiding this comment.
Moved out of utils to fix circular dependency
bmingles
changed the title
This was
linked to
issues
Nov 13, 2024
mofojed
approved these changes
Nov 15, 2024
| ): Promise<ConnectionState[]> { | ||
| const filteredConnections: ConnectionState[] = []; | ||
|
|
||
| for await (const connection of iterateConnectionsForConsoleType( |
There was a problem hiding this comment.
Never used this syntax before, TIL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.