Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private key based auth #32

Closed
Tracked by #17
bmingles opened this issue Jul 12, 2024 · 2 comments · Fixed by #159
Closed
Tracked by #17

Private key based auth #32

bmingles opened this issue Jul 12, 2024 · 2 comments · Fixed by #159
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bmingles
Copy link
Collaborator

bmingles commented Jul 12, 2024

As an enterprise user, I'd like to be able to authenticate via a private key.

Relevant Docs:

Notes from conversation with Charles:
Slack - July 30 2:05 PM

The SessionManager.__make_session retrieves an authentication token (I know the JS API can do that), and configures authentication headers and Envoy headers for the udnerlying core session.

This is a Python implementation of the private key authentication:

@bmingles bmingles added enhancement New feature or request triage labels Jul 12, 2024
@devinrsmith
Copy link
Member

It's not so much the user authenticating via a certificate; it's that the client trusts the servers TLS certificate.

@bmingles
Copy link
Collaborator Author

bmingles commented Jul 12, 2024

Ah, I had conflated 2 different issues. I've created #35 to support trusting of certificates. We'll still need this one to support enterprise customers who want to login to their server via a private key.

@bmingles bmingles changed the title Cert based auth Private key based auth Jul 12, 2024
@vbabich vbabich added this to the July 2024 milestone Jul 16, 2024
@vbabich vbabich removed the triage label Jul 16, 2024
@bmingles bmingles self-assigned this Oct 10, 2024
bmingles added a commit that referenced this issue Oct 15, 2024
bmingles added a commit that referenced this issue Oct 16, 2024
bmingles added a commit that referenced this issue Oct 16, 2024
bmingles added a commit that referenced this issue Oct 16, 2024
bmingles added a commit that referenced this issue Oct 23, 2024
bmingles added a commit that referenced this issue Oct 23, 2024
bmingles added a commit that referenced this issue Oct 23, 2024
bmingles added a commit that referenced this issue Oct 23, 2024
@mofojed mofojed modified the milestones: July 2024, November 2024 Nov 6, 2024
@bmingles bmingles linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants