Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache DHE Core+ jsapis by worker kind / engine type #174

Open
bmingles opened this issue Nov 12, 2024 · 0 comments
Open

Cache DHE Core+ jsapis by worker kind / engine type #174

bmingles opened this issue Nov 12, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@bmingles
Copy link
Collaborator

The extension currently stores Core+ jsapi downloads by worker URL. Some workers might use the same api version, so it would be more optimal to cache by worker kind / engine type to avoid duplicate downloads.

e.g. We do this in the web here:
https://github.com/deephaven-ent/iris/blob/0fccc395d44974571e71085c762b68c151c7ca58/web/client-ui/src/main/AppMainContainer.tsx#L587
@bmingles bmingles added enhancement New feature or request triage labels Nov 12, 2024
@bmingles bmingles mentioned this issue Nov 12, 2024
Merged
@vbabich vbabich removed the triage label Nov 19, 2024
@vbabich vbabich added this to the Backlog milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bmingles @vbabich