Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting lines only gives an option to run the entire file #122

Open
chipkent opened this issue Sep 6, 2024 · 1 comment
Open

Highlighting lines only gives an option to run the entire file #122

chipkent opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working question Further information is requested

Comments

@chipkent
Copy link
Member

chipkent commented Sep 6, 2024

Highlighting lines only gives an option to run the entire file

image
@chipkent chipkent added bug Something isn't working triage labels Sep 6, 2024
@mofojed mofojed added question Further information is requested and removed triage labels Sep 10, 2024
@mofojed
Copy link
Member

mofojed commented Sep 10, 2024

@chipkent we moved that functionality to a hover provider, so if you hover the selection you should see a "Run Deephaven selected lines" button:
image
That was done with #110
The issue with the code lens is it caused things to shift around and you could accidentally trigger it when selecting/reselecting some text.
@bmingles maybe we should be using a Code Action provider instead? https://microsoft.github.io/monaco-editor/typedoc/functions/languages.registerCodeActionProvider.html

In any case @chipkent it won't appear as a code lens, as those aren't great to change around when selection is changing in a doc. Run Deephaven File at the top is still provided as a code lens for convenience, as it doesn't appear/disappear/move the document around when you change selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants