Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deephaven express: Not using WebGL for line plots #991

Open
mofojed opened this issue Nov 5, 2024 · 1 comment · May be fixed by #992
Open

Deephaven express: Not using WebGL for line plots #991

mofojed opened this issue Nov 5, 2024 · 1 comment · May be fixed by #992
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Nov 5, 2024

Description

If you create a line plot in plotly express, it seems to just use the canvas instead of the WebGL optimized canvas. We should be using WebGL to render when it is enabled. With legacy plots it does use WebGL.

Steps to reproduce

  1. Run the following:
from deephaven.plot import express as dx
from deephaven.plot.figure import Figure

_stocks = dx.data.stocks()

p = dx.line(_stocks, "Timestamp", "Random")
p_legacy = Figure().plot_xy(series_name="Plot", t=_stocks, x="Timestamp", y="Random").show()
  1. Check the plot p_legacy Chart component props data type
  2. From the React DevTools, check the plot p Chart component props data type

Expected results
2. Plot type should be scattergl
3. Plot type should be scattergl

Actual results
2. Plot type is scattergl for the legacy plot
3. Plot type is just scatter for the express plot

Additional details and attachments
image

Versions

Engine Version: 0.36.1
Web UI Version: 0.90.0
Java Version: 11.0.24
Barrage Version: 0.6.0
Browser Name: Chrome 129
OS Name: Linux
@deephaven/js-plugin-plotly-express: 0.11.2
@deephaven/js-plugin-ui: 0.22.0

@mofojed mofojed added bug Something isn't working triage labels Nov 5, 2024
@mofojed
Copy link
Member Author

mofojed commented Nov 5, 2024

Seems p_scatter = dx.scatter(_stocks, "Timestamp", "Random") does render with scattergl, perhaps we only disabled this on line plots when downsampling is enabled?

@jnumainville jnumainville linked a pull request Nov 6, 2024 that will close this issue
@vbabich vbabich added this to the November 2024 milestone Nov 12, 2024
@vbabich vbabich removed the triage label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants