-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Fix a TimeRange off-by-one bug in nanosecond calculation #302
Comments
It's not obvious that anything needs to change in the Pydocs, since business day length is not explicitly mentioned anywhere. It is also not obvious that anything needs to change in the Calendars guide. However, something may need to change here. In particular, some methods like |
The The bug was in how The only other change of note -- which may require documentation --, is some additional configurability in the calendar XML files. Also see https://github.com/deephaven/deephaven-core/pull/5648/files#diff-54ece697448ad466b3a5b659e70da856bbe21c18973c787e62c2506ba8b68fc5. |
This is the only real place I can find config details on these XML files: https://deephaven.io/core/javadoc/io/deephaven/time/calendar/BusinessCalendarXMLParser.html The other "docs" is this example, linked to from the Calendars guide: https://github.com/deephaven/deephaven-core/blob/main/props/configs/src/main/resources/calendar/UTC.calendar I can't find anywhere else where we document config details. The calendars guide just points to the examples in GH, and if you're looking, you can find the Javadoc. If we want docsite docs for these config details, that is a bigger PR than this ticket warrants. |
Looks like there is no work to do for this PR. |
This issue was auto-generated
PR: deephaven/deephaven-core#5648
Author: chipkent
Original PR Body
Fix a TimeRange off-by-one bug in nanosecond calculation.
Resolves #5646
BREAKING CHANGE: The length of a business day was being incorrectly computed by 1 ns. To keep the business day length the same for existing calendars, the close of a business period has been changed from inclusive to exclusive. This default behavior can be overridden by using
<includeClose>true</includeClose>
when specifying time ranges. This will include the closing time for the range and will result in a business period that is 1 ns longer. Business calendars using the legacy format must be upgraded to the current format to use<includeClose>true</includeClose>
.The text was updated successfully, but these errors were encountered: