Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in aggregations and query library functions. #206

Closed
deephaven-internal opened this issue May 6, 2024 · 1 comment
Closed
Assignees
Labels
autogenerated update An update to existing documentation

Comments

@deephaven-internal
Copy link

This issue was auto-generated

PR: deephaven/deephaven-core#5368
Author: chipkent

Original PR Body

Aggregation operations in query library functions and built-in query aggregations are inconsistent. This PR makes them consistent. Query library functions were changed.

  • percentile now returns the primitive type.
  • sum returns a widened type of double for floating point inputs or long for integer inputs.
  • product returns a widened type of double for floating point inputs or long for integer inputs.
  • cumsum returns a widened type of double[] for floating point inputs or long[] for integer inputs.
  • cumprod returns a widened type of double[] for floating point inputs or long[] for integer inputs.
  • wsum returns a widened type of long for all integer inputs and double for inputs containing floating points.

Note: Because the types have changed, the NULL return values have changed as well.

Resolves #4023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated update An update to existing documentation
Projects
None yet
Development

No branches or pull requests

3 participants