Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Better Error Handling for Barrage Connections #375

Merged

Conversation

stanbrub
Copy link
Collaborator

  • Added more catches of possible error message during the creation of sessions to provide more context
  • Use close() when errors are found in the constructor in case channel was created before error occurred
  • Update close() to function better on partially completed session/console creation

@stanbrub stanbrub self-assigned this Oct 28, 2024
@stanbrub stanbrub linked an issue Oct 28, 2024 that may be closed by this pull request
@stanbrub stanbrub changed the title Better Error Handling for Barrage Connections refactor: Better Error Handling for Barrage Connections Oct 28, 2024
@stanbrub stanbrub merged commit 3878744 into deephaven:main Oct 28, 2024
3 checks passed
@stanbrub stanbrub deleted the improve-barrage-connection-error-handling branch October 28, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Barrage Client Error Handling
1 participant