Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Hash Platform Detail #335

Open
stanbrub opened this issue Aug 12, 2024 · 0 comments
Open

Commit Hash Platform Detail #335

stanbrub opened this issue Aug 12, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@stanbrub
Copy link
Collaborator

stanbrub commented Aug 12, 2024

Pull the deephaven-core commit hash into the benchmark platform details.

  • Add support to the DeephavenController to grab properties from docker container inspect <container-id>
  • Add grabbing the label 'org.opencontainers.image.revision' to the StandardTestRunner, FileTestRunner and CompareTestRunner
  • Requires: Add commit SHA to branch / edge images deephaven-server-docker#114
  • Note: This will not work against native runs, since the commit hash is only in the docker images
  • Note: This also does not work with Release imasges. Instead, the commit hash can be retreived like the following
    • curl https://api.github.com/repos/deephaven/deephaven-core/commits/v0.35.0 | grep '"sha":' | head -1 | cut -d'"' -f4
@stanbrub stanbrub added the enhancement New feature or request label Aug 12, 2024
@stanbrub stanbrub self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant