Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale DateTimeUtils Benchmarks #184

Closed
stanbrub opened this issue Oct 16, 2023 · 0 comments · Fixed by #185
Closed

Rescale DateTimeUtils Benchmarks #184

stanbrub opened this issue Oct 16, 2023 · 0 comments · Fixed by #185
Assignees
Labels
enhancement New feature or request

Comments

@stanbrub
Copy link
Collaborator

The DateTimeUtils functions are somewhat inefficient when it comes to creation of objects. This is because the JDK does not allow creation of some instance types (e.g. ZonedDateTime) with primitives in the public interfaces. The result is a lot of unnecessary object create to convert, for example, nanos to seconds-with-nanos.

The current scaling makes some operations hit the heap max. Even though the operation completes, the benchmark results can be skewed because GC is spinning. This can result in a high operational variability between operation runs.

  • Re-scale the DateUtilsFormulaTest benchmarks to fit better in the available heap.
@stanbrub stanbrub added the enhancement New feature or request label Oct 16, 2023
@stanbrub stanbrub self-assigned this Oct 16, 2023
@stanbrub stanbrub linked a pull request Oct 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant