Isomorphism #185
Open
Isomorphism #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,5 +32,8 @@ | |||
| "scripts": { | |||
| "boosh": "smoosh make ./build.json", | |||
| "test": "node ./test.js" | |||
| }, | |||
| "dependencies": { | |||
| "xhr2": "0.1.0" | |||
There was a problem hiding this comment.
this is going to add the library to the client. if you build this with ender or browserify i'm not so sure this library will work anymore in the browser (which is its original intention)
There was a problem hiding this comment.
It worked for me in Webpack. I've since moved on to https://github.com/matthew-andrews/isomorphic-fetch
Feel free to make any changes you see fit to make it more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced your hardcoded references to
windowso Reqwest can use XHR polyfills when being run on the server. This is the work I referenced in #153.