Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS tlog Implementation #1588

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

CMS tlog Implementation #1588

wants to merge 21 commits into from

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Nov 29, 2021

This is re-implements the various CMS functionality in the new plugin/hook model that was introduced with the tlog implementation.

@xaur
Copy link

xaur commented Nov 30, 2021

Is there a plan how to migrate past data into tstore?

@lukebp
Copy link
Member

lukebp commented Nov 30, 2021

Is there a plan how to migrate past data into tstore?

CMS will run into the same problems that Pi has, which have not been fun to deal with. All signatures will be broken, all timestamps will be broken, and it's a lot of work to build out a tool to convert the data types between the git backend and the tstore backend.

The signatures being broken is the main source of pain because it breaks a lot of built in validation both client side and server side.

I would recommend following the same route as Pi. Throw up an archived site for now that contains the git backend data and gives you time to figure out the best way forward.

@xaur
Copy link

xaur commented Nov 30, 2021

Thanks for the details.

I just want to highlight that we absolutely need to retain access to past invoice data.

Archived site may work, but fragmenting the database will have consequences. Perhaps the worst will be broken reporting on owned proposals. Imagine I need to report to the stakeholders on my budget spending. Proposal reports in the store-based CMS will be incomplete if it does not have all data in. I would very much prefer to avoid such disruption and not lose the numbers I need to show to the stakeholders once in a while.

Could CMS reuse any of the Git>tstore migration developed in #1425 ?

@lukebp
Copy link
Member

lukebp commented Nov 30, 2021

Could CMS reuse any of the Git>tstore migration developed in #1425 ?

Only the comment parts, which doesn't help very much.

Also, this decision has nothing to do with you. Everybody understands that, ideally, we don't want two databases. You're stating the obvious. I will be ignoring all future comments from you on this issue and I shouldn't have entertained your questions in the first place. That's my mistake.

@alexlyp alexlyp changed the title [WIP] CMS tlog Implementation CMS tlog Implementation Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants