Don't depend on dcrdata/exchanges. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcrdata/exchanges depends on decred/dcrdex, which at time of writing has over 150 dependencies of its own. All of these extra deps can be avoided by simply copy/pasting the necessary parts of exchanges.ExchangeRates into this project (grand total two lines of code).
This was referenced Jan 26, 2024
dajohi
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcrdata/exchanges depends on decred/dcrdex, which at time of writing has
over 150 dependencies of its own. All of these extra deps can be avoided
by simply copy/pasting the necessary parts of exchanges.ExchangeRates
into this project (grand total two lines of code).