From 89827b541dd2ccad6e4fbe2b00bd2c1748dc02da Mon Sep 17 00:00:00 2001 From: Donald Adu-Poku Date: Wed, 16 Sep 2020 12:22:14 +0000 Subject: [PATCH] pool: resolve review issues (3 of x). --- pool/client.go | 6 ------ pool/upgrades_test.go | 4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/pool/client.go b/pool/client.go index 5da61b62..d7067b7e 100644 --- a/pool/client.go +++ b/pool/client.go @@ -453,12 +453,6 @@ func (c *Client) handleSubmitWorkRequest(ctx context.Context, req *Request, allo // by the mining node. work := NewAcceptedWork(hash.String(), header.PrevBlock.String(), header.Height, c.account, c.cfg.FetchMiner()) - if err != nil { - sErr := NewStratumError(Unknown, err) - resp := SubmitWorkResponse(*req.ID, false, sErr) - c.ch <- resp - return err - } err = work.Create(c.cfg.DB) if err != nil { // If the submitted accepted work already exists, ignore the diff --git a/pool/upgrades_test.go b/pool/upgrades_test.go index 809817f5..f0736748 100644 --- a/pool/upgrades_test.go +++ b/pool/upgrades_test.go @@ -185,8 +185,8 @@ func verifyV4Upgrade(t *testing.T, db *bolt.DB) { err := db.View(func(tx *bolt.Tx) error { pbkt := tx.Bucket(poolBkt) if pbkt == nil { - return fmt.Errorf("%s: bucket %s not found", string(poolBkt), - funcName) + return fmt.Errorf("%s: bucket %s not found", funcName, + string(poolBkt)) } v := pbkt.Get([]byte("txfeereserve"))