mm/binance: Use filters and withdraw multiple #3093
+137
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
force-pushed
the
priceFilters
branch
from
06a8b19
to
47d2deb
Compare
buck54321
requested changes
Nov 28, 2024
There was a problem hiding this comment.
I think this can be much simpler. Please review these two suggestions.
dev-warrior777
approved these changes
Nov 28, 2024
client/mm/libxc/binance.go
Outdated
| } | ||
|
|
||
| req.Header = header | ||
|
|
||
| return req, nil | ||
| // bnc.log.Tracef("Sending request: %+v", req) |
There was a problem hiding this comment.
Do you still need this?
Comment on lines
63
to
65
| // WithdrawMax float64 `json:"withdrawMax,string"` | ||
| WithdrawMin float64 `json:"withdrawMin,string"` | ||
| // SameAddress bool `json:"sameAddress"` |
There was a problem hiding this comment.
Maybe remove commented.
There was a problem hiding this comment.
I think it's ok.. good to know what other fields there are without having to check the API.
|
Needs a rebase, but look great. |
buck54321
reviewed
Nov 29, 2024
client/mm/libxc/binance.go
Outdated
| conv := float64(qui.Conventional.ConversionFactor) / float64(bui.Conventional.ConversionFactor) * calc.RateEncodingFactor | ||
| market.RateStep = uint64(math.Round(filter.TickSize * conv)) | ||
| market.MinPrice = uint64(math.Round(filter.MinPrice * conv)) | ||
| market.MaxPrice = uint64(math.Round(filter.MaxPrice * conv)) // Why was the conv outside of the math.Round? |
There was a problem hiding this comment.
// Why was the conv outside of the math.Round?
Not sure. Whadya expect me to test my code suggestions? 🤪
There was a problem hiding this comment.
Lol that comment was kind of meant for myself.
The price and lot size filters were not being used, leading to trade errors. The withdraw multiple was also not being used leading to withdraw errors.
martonp
force-pushed
the
priceFilters
branch
from
abde4ea
to
3db198f
Compare
JoeGruffins
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The price and lot size filters were not being used, leading to trade
errors. The withdraw multiple was also not being used leading to withdraw
errors.