multi: Add ExchangeWalletCustom to support external btc-clone wallets
#2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
changed the title
ExchangeWalletCustom to support extrnal wallets ExchangeWalletCustom to support external btc-clone wallets
|
cc: @dmigwi |
ukane-philemon
force-pushed
the
btc-node
branch
from
384278c
to
9129972
Compare
|
cc: @buck54321 |
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
ukane-philemon
force-pushed
the
btc-node
branch
from
9129972
to
5225705
Compare
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
martonp
approved these changes
Nov 20, 2024
JoeGruffins
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an improved version of #2636.
ExchangeWalletCustombtc.Walletmethods. This aligns with the existing pattern -dcr.Walletmethods are exported. Custom wallets would now implement thebtc.Walletinterface directly.Each of these changes is in a separate commit to ease review.
Other related commit: https://github.com/decred/dcrdex/pull/1227/files#diff-cd95defa7320b76287f90152b40ee5ec5edec59ca9af2eb9579ecda539ece20a