Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: mm bot notification handling exception (when bot is not ready yet) #3100

Open
norwnd opened this issue Nov 25, 2024 · 0 comments
Open

ui: mm bot notification handling exception (when bot is not ready yet) #3100

norwnd opened this issue Nov 25, 2024 · 0 comments

Comments

@norwnd
Copy link
Contributor

norwnd commented Nov 25, 2024

I've noticed the following exception thrown in JS console:

image

it seems the following notification handler runs even before MM bot can handle it (has proper market set up on it):

      runstats: (note: RunStatsNote) => {
        this.mm.update()
        if (note.baseID !== this.market.base.id || note.quoteID !== this.market.quote.id || note.host !== this.market.dex.host) return
        if (Boolean(this.mmRunning) !== Boolean(note.stats)) {
          this.mmRunning = Boolean(note.stats)
          this.resolveOrderFormVisibility()
        }
      },

doesn't seem like that leads to any problems in practice, but

  • perhaps we might miss some important notification(s) this way causing mm bot UI widget to get stuck until page is refreshed or something
  • keeping console log clean would help when debugging other issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant