wire: Add p2p mixing messages. #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
force-pushed
the
wire-mix
branch
3 times, most recently
from
a83f02a
to
599df65
Compare
jrick
force-pushed
the
wire-mix
branch
4 times, most recently
from
ef7dace
to
be7d77b
Compare
This was referenced Nov 7, 2023
davecgh
requested changes
Nov 21, 2023
wire/msgmixcm_test.go
Outdated
| "github.com/decred/dcrd/chaincfg/chainhash" | ||
| ) | ||
|
|
||
| func TestMixCMWire(t *testing.T) { |
There was a problem hiding this comment.
These tests have pretty poor test coverage:
$ go test -coverprofile=cov.out >/dev/null && go tool cover -func=cov.out | grep MixCM
github.com/decred/dcrd/wire/msgmixcm.go:205: NewMsgMixCM 66.7%
There was a problem hiding this comment.
Current test coverage percents:
$ go test -coverprofile=cov.out >/dev/null && go tool cover -func=cov.out | grep msgmix github.com/decred/dcrd/wire/msgmixciphertexts.go:35: BtcDecode 76.9% github.com/decred/dcrd/wire/msgmixciphertexts.go:83: BtcEncode 63.6% github.com/decred/dcrd/wire/msgmixciphertexts.go:109: Hash 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:119: WriteHash 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:136: writeMessageNoSignature 65.2% github.com/decred/dcrd/wire/msgmixciphertexts.go:181: WriteSignedData 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:188: Command 100.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:194: MaxPayloadLength 100.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:204: Pub 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:209: Sig 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:214: Expires 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:219: PrevMsgs 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:224: Sid 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:229: GetRun 0.0% github.com/decred/dcrd/wire/msgmixciphertexts.go:236: NewMsgMixCiphertexts 100.0% github.com/decred/dcrd/wire/msgmixconfirm.go:38: BtcDecode 73.9% github.com/decred/dcrd/wire/msgmixconfirm.go:81: BtcEncode 63.6% github.com/decred/dcrd/wire/msgmixconfirm.go:107: Hash 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:117: WriteHash 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:134: writeMessageNoSignature 68.4% github.com/decred/dcrd/wire/msgmixconfirm.go:172: WriteSignedData 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:179: Command 100.0% github.com/decred/dcrd/wire/msgmixconfirm.go:185: MaxPayloadLength 100.0% github.com/decred/dcrd/wire/msgmixconfirm.go:195: Pub 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:200: Sig 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:205: Expires 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:210: PrevMsgs 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:215: Sid 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:220: GetRun 0.0% github.com/decred/dcrd/wire/msgmixconfirm.go:227: NewMsgMixConfirm 66.7% github.com/decred/dcrd/wire/msgmixdcnet.go:33: BtcDecode 76.0% github.com/decred/dcrd/wire/msgmixdcnet.go:78: BtcEncode 63.6% github.com/decred/dcrd/wire/msgmixdcnet.go:104: Hash 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:114: WriteHash 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:131: writeMessageNoSignature 61.5% github.com/decred/dcrd/wire/msgmixdcnet.go:175: writeMixVects 70.6% github.com/decred/dcrd/wire/msgmixdcnet.go:206: readMixVects 64.0% github.com/decred/dcrd/wire/msgmixdcnet.go:252: WriteSignedData 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:259: Command 100.0% github.com/decred/dcrd/wire/msgmixdcnet.go:265: MaxPayloadLength 100.0% github.com/decred/dcrd/wire/msgmixdcnet.go:275: Pub 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:280: Sig 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:285: Expires 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:290: PrevMsgs 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:295: Sid 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:300: GetRun 0.0% github.com/decred/dcrd/wire/msgmixdcnet.go:307: NewMsgMixDCNet 100.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:48: BtcDecode 75.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:86: BtcEncode 63.6% github.com/decred/dcrd/wire/msgmixkeyexchange.go:112: Hash 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:122: WriteHash 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:139: writeMessageNoSignature 68.8% github.com/decred/dcrd/wire/msgmixkeyexchange.go:173: WriteSignedData 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:180: Command 100.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:186: MaxPayloadLength 100.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:196: Pub 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:201: Sig 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:206: Expires 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:211: PrevMsgs 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:216: Sid 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:221: GetRun 0.0% github.com/decred/dcrd/wire/msgmixkeyexchange.go:228: NewMsgMixKeyExchange 100.0% github.com/decred/dcrd/wire/msgmixpairreq.go:77: Pairing 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:105: BtcDecode 69.0% github.com/decred/dcrd/wire/msgmixpairreq.go:206: BtcEncode 63.6% github.com/decred/dcrd/wire/msgmixpairreq.go:232: Hash 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:242: WriteHash 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:259: writeMessageNoSignature 62.1% github.com/decred/dcrd/wire/msgmixpairreq.go:363: WriteSignedData 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:370: Command 100.0% github.com/decred/dcrd/wire/msgmixpairreq.go:376: MaxPayloadLength 100.0% github.com/decred/dcrd/wire/msgmixpairreq.go:386: Pub 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:391: Sig 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:396: Expires 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:401: PrevMsgs 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:406: Sid 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:411: GetRun 0.0% github.com/decred/dcrd/wire/msgmixpairreq.go:418: NewMsgMixPairReq 100.0% github.com/decred/dcrd/wire/msgmixsecrets.go:36: writeMixVect 64.3% github.com/decred/dcrd/wire/msgmixsecrets.go:63: readMixVect 66.7% github.com/decred/dcrd/wire/msgmixsecrets.go:102: BtcDecode 71.4% github.com/decred/dcrd/wire/msgmixsecrets.go:152: BtcEncode 63.6% github.com/decred/dcrd/wire/msgmixsecrets.go:178: Hash 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:188: WriteHash 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:204: writeMessageNoSignature 71.4% github.com/decred/dcrd/wire/msgmixsecrets.go:233: WriteSignedData 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:240: Command 100.0% github.com/decred/dcrd/wire/msgmixsecrets.go:246: MaxPayloadLength 100.0% github.com/decred/dcrd/wire/msgmixsecrets.go:256: Pub 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:261: Sig 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:266: Expires 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:275: PrevMsgs 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:280: Sid 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:285: GetRun 0.0% github.com/decred/dcrd/wire/msgmixsecrets.go:292: NewMsgMixSecrets 100.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:47: BtcDecode 66.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:125: BtcEncode 63.6% github.com/decred/dcrd/wire/msgmixslotreserve.go:151: Hash 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:161: WriteHash 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:178: writeMessageNoSignature 58.3% github.com/decred/dcrd/wire/msgmixslotreserve.go:256: WriteSignedData 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:263: Command 100.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:269: MaxPayloadLength 100.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:279: Pub 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:284: Sig 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:289: Expires 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:294: PrevMsgs 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:299: Sid 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:304: GetRun 0.0% github.com/decred/dcrd/wire/msgmixslotreserve.go:311: NewMsgMixSlotReserve 100.0%
It's still missing hitting the error paths, which would probably require crafting messages to exceed the maximum constants.
jrick
force-pushed
the
wire-mix
branch
4 times, most recently
from
6693718
to
6dd9ce6
Compare
jrick
commented
Dec 4, 2023
davecgh
requested changes
Dec 20, 2023
davecgh
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Alright, everything has been quite thoroughly reviewed including attempts to intentionally send bogus data that will break things as well as subjecting it to fuzzing.
The only full bug I hit is the one for the size checks for the kpcount that I identified in inline.
Super nice job overall on this. Once everything is addressed, I'll give it another pass and it should be ready to go in.
davecgh
requested changes
Feb 22, 2024
|
One note before this does go in, I am considering removing the expiry field from all messages except the pair request (and from the mixing message interface). The expiry checks on the other messages are generally useless because we must receive KEs even if they reference unknown PRs (but we will require them to reference at least one known PR), and there's no way to verify that the stated expiry is the minimum of all PRs when some are unknown. We will still expire sessions that reference an expired PR, so we don't need to rely on each message's individual expiry field. |
|
No objections to removing the Expiry to me and it will result in a slightly more efficient messages. I'll hold off until you do that then. |
davecgh
reviewed
Mar 19, 2024
These messages implement the stages of a cspp mix. Messages will be broadcast to all full nodes and all peers participating in mixing through inventory messages.
davecgh
approved these changes
Mar 19, 2024
davecgh
added
the
wire protocol change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These messages implement the stages of a cspp mix. Messages will be broadcast to all full nodes and all peers participating in mixing through inventory messages.