Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for signed-ietf-json-patch #8

Closed
tmarkovski opened this issue Feb 22, 2021 · 0 comments · Fixed by #33
Closed

Implement support for signed-ietf-json-patch #8

tmarkovski opened this issue Feb 22, 2021 · 0 comments · Fixed by #33
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tmarkovski
Copy link
Member

tmarkovski commented Feb 22, 2021

As described here https://github.com/decentralized-identity/did-spec-extensions/blob/master/parameters/signed-ietf-json-patch.md

Objective

The key DID method is designed as deterministic key resolution that resolves into a fixed DID document. The identifier of the DID method is fingerprint of the public part of the key pair; as such it doesn't now provide registration for additional fields in the DID document.
RFC 6902 defines a mechanic that can be applied to a JSON object to patch the document which can be used to extend the DID document.
The Signed IETF JSON Patch DID Extension describes how this can be utilized in a DID Document by allowing the DID URI to extend it's document with signed data.

Implementation

This implementation should ensure that the API can be extended with the JSON Patch operations by taking an input of (operation, path, json) and producing a result that contains the DID URI of the key in question with the signedIetfJsonPatch URL parameter and it's value.
The reverse operation for resolving this URL would resolve the DID document with the patched JSON. The library should perform all needed validations to ensure that the controller is the original signer of the patched data.

Test Vectors

TODO

Breaking Changes

None expected, but there may be changes in API and DID Document structs that will impact current implementations.

Related Issues

transmute-industries/did-key.js#72

w3c-ccg/did-method-key#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant