Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Incorrect Base64URL encoding used (should not use padding) #21

Open
kdenhartog opened this issue Nov 25, 2019 · 0 comments · May be fixed by #24
Open

Incorrect Base64URL encoding used (should not use padding) #21

kdenhartog opened this issue Nov 25, 2019 · 0 comments · May be fixed by #24
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kdenhartog
Copy link
Contributor

In order to be compliant with JWE/JWS specification we should be using no padding with the JWE/JWS libraries. This is incorrectly implemented and should be switched.
@kdenhartog kdenhartog added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Nov 25, 2019
@kg0r0 kg0r0 linked a pull request Apr 10, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Incorrect Base64URL encoding used kg0r0/DIDComm-js
1 participant
@kdenhartog