Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow:magic not working? #170

Open
cameronsstone opened this issue Dec 23, 2020 · 0 comments
Open

workflow:magic not working? #170

cameronsstone opened this issue Dec 23, 2020 · 0 comments

Comments

@cameronsstone
Copy link

I was debugging an issue in tilmanginzel's alfred-bluetooth-workflow (20), and noticed that the workflow:magic command was not working, though the other magic commands were. Looking into the code, I noticed that workflow.py's list_magic() method ends with a self.send_feedback(), but then returns control to the main workflow method, which seems to lead to a duplicate call to send_feedback and Alfred getting confused and not showing the magic list. I found I could restore the magic list by any of the following:

  1. Removing the send_feedback from the main method. That obviously broke the workflow functionality, but it proved my hypothesis.
  2. Adding a sys.exit(0) after the send_feedback in list_magic
  3. Removing the send_feedback from list_magic

Both 2 & 3 worked - restoring workflow:magic functionality without affecting the main workflow functionality, but I suspect 2 is probably a more robust fix.

BTW, I just checked alfred-convert, and it, too, doesn't seem to work for workflow:magic.

I'm using Alfred 4.3 [1205].

bskim45 added a commit to bskim45/alfred-workflow that referenced this issue Jan 15, 2022
bskim45 added a commit to bskim45/alfred-coin-ticker that referenced this issue Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant