cascade options

datashaman · Aug 17, 2024 · 9f84639 · 9f84639
1 parent b1cb539
commit 9f84639
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/config/translators.php b/config/translators.php
@@ -18,14 +18,16 @@
         ],
 
         'google-v2' => [
-            'project' => env('TRANSLATORS_GOOGLE_KEY'),
+            'construct' => [
+                'keyFilePath' => env('TRANSLATORS_GOOGLE_KEY_FILE', base_path('keys/google.json')),
+            ],
             'options' => [
                 'format' => 'text',
             ],
         ],
 
         'google-v3' => [
-            'project' => env('TRANSLATORS_GOOGLE_PROJECT'),
+            'project' => env('TRANSLATORS_GOOGLE_PROJECT', env('GOOGLE_CLOUD_PROJECT')),
             'options' => [],
         ],
 

diff --git a/src/LaravelTranslatorsServiceProvider.php b/src/LaravelTranslatorsServiceProvider.php
@@ -19,10 +19,7 @@ public function register(): void
             $this->app->singleton(Client::class, fn () => OpenAI::client(config('translators.services.openai.api_key')));
         }
 
-        $this->app->singleton(TranslateClient::class, fn () => new TranslateClient([
-            'key' => config('translators.services.google-v2.key'),
-        ]));
-
+        $this->app->singleton(TranslateClient::class, fn () => new TranslateClient(config('translators.services.google-v2.construct')))
         $this->app->singleton(Translator::class, fn () => new Translator(config('translators.services.deepl.api_key')));
         $this->app->singleton('translator-manager', fn ($app) => new TranslatorManager($app));
     }

diff --git a/src/Translators/GoogleV2Translator.php b/src/Translators/GoogleV2Translator.php
@@ -3,6 +3,7 @@
 namespace Datashaman\LaravelTranslators\Translators;
 
 use Datashaman\LaravelTranslators\Contracts\TranslatorInterface;
+use Google\Cloud\Translate\V2\TranslateClient;
 
 class GoogleV2Translator implements TranslatorInterface
 {