fix: lock attach table's snapshot location #16952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
During instantiating attach table instance, "lock" table's snapshot location( which is extracted from the last_snapshot_hint file), by
OPT_KEY_SNAPSHOT_LOCATION
NOTE:
[
databend_common_base::runtime::Runtime::block_on
] (not tokio's) is used to execute async code within a sync context. It seems to be safe (not blocking other async tasks), but I am not quite sure.@zhang2014 Please help review this usage.
Tests
Type of change
This change is