Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev dependecy chai required in production? #6

Open
Tauri28 opened this issue Mar 29, 2021 · 3 comments
Open

Dev dependecy chai required in production? #6

Tauri28 opened this issue Mar 29, 2021 · 3 comments

Comments

@Tauri28
Copy link

Tauri28 commented Mar 29, 2021

I have notices, that the production code is using chai for testing and I am getting
Error: Cannot find module 'chai'
since it is listed under devDependencies

@ashleydavis
Copy link
Member

Ok thanks for letting me know.

Feel free to move the code that depends on chai or add chai to normal dependencies. If you submit a PR I'll accept and publish a new version.

@thegafo
Copy link

thegafo commented Oct 5, 2021

I'm receiving the same error. I'll take a look at it later and submit a PR if I can.

@ashleydavis
Copy link
Member

Please feel to remove chai for assertions and just throw exceptions... that way we can remove chai as a dependency altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants