Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pf4): Upgrade to PatternFly 6 #1492

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wise-king-sullyman
Copy link

@wise-king-sullyman wise-king-sullyman commented Nov 7, 2024

Description

Upgrades the pf4-component-mapper PatternFly dependencies to our v6 release

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • Test coverage for new code (if applicable)
  • Documentation update (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 7:07pm

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (31d5e90) to head (32afa44).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1492      +/-   ##
==========================================
- Coverage   94.49%   94.48%   -0.01%     
==========================================
  Files         210      210              
  Lines        3975     3973       -2     
  Branches     1629     1628       -1     
==========================================
- Hits         3756     3754       -2     
  Misses        219      219              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hyperkid123
Copy link
Member

@wise-king-sullyman we will make this a major release. We do have some time still before this is absolutely necessary.

We will also have to do a follow-up and update the Docs code samples templates.

@Hyperkid123 Hyperkid123 self-requested a review November 8, 2024 08:27
@wise-king-sullyman
Copy link
Author

@Hyperkid123 is there anything further I need to do on this PR at the moment?

@Hyperkid123
Copy link
Member

Not right now. I just need some time to go trough all the changes and make sure we get the proper release. I think it can sit here for a bit, we are in no rush just yet. I hope I'll have some time for review in a few days.

@Hyperkid123
Copy link
Member

@wise-king-sullyman ok, I think there is still some work remaining. Tried running the pf playground and there are some missing CSS errors:

You can run the playground by switching to the PF component mapper dir and running yarn start

@wise-king-sullyman
Copy link
Author

@Hyperkid123 resolved the errors, but I think I still have some work to do now that I've seen this playground.

It's hard to say for sure though because I tried to pull master and run the playground and compare, and it seems to be missing all of the PF styles? Not sure if that's just a me thing though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants