-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pf4): Upgrade to PatternFly 6 #1492
base: master
Are you sure you want to change the base?
feat(pf4): Upgrade to PatternFly 6 #1492
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
- Coverage 94.49% 94.48% -0.01%
==========================================
Files 210 210
Lines 3975 3973 -2
Branches 1629 1628 -1
==========================================
- Hits 3756 3754 -2
Misses 219 219 ☔ View full report in Codecov by Sentry. |
@wise-king-sullyman we will make this a major release. We do have some time still before this is absolutely necessary. We will also have to do a follow-up and update the Docs code samples templates. |
@Hyperkid123 is there anything further I need to do on this PR at the moment? |
Not right now. I just need some time to go trough all the changes and make sure we get the proper release. I think it can sit here for a bit, we are in no rush just yet. I hope I'll have some time for review in a few days. |
@wise-king-sullyman ok, I think there is still some work remaining. Tried running the pf playground and there are some missing CSS errors:
You can run the playground by switching to the PF component mapper dir and running |
@Hyperkid123 resolved the errors, but I think I still have some work to do now that I've seen this playground. It's hard to say for sure though because I tried to pull master and run the playground and compare, and it seems to be missing all of the PF styles? Not sure if that's just a me thing though. |
Description
Upgrades the pf4-component-mapper PatternFly dependencies to our v6 release
Checklist: (please see documentation page for more information)
Yarn build
passesYarn lint
passesYarn test
passesfix|feat({scope}): {description}
fix(pf3): wizard correctly handles next button
Fix button on documenation example page